Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Rollup Integrations #15142

Merged
merged 3 commits into from Oct 9, 2021
Merged

Docs: Update Rollup Integrations #15142

merged 3 commits into from Oct 9, 2021

Conversation

xiaohp
Copy link
Contributor

@xiaohp xiaohp commented Oct 8, 2021

Update Rollup ESLint plugin

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Update Rollup ESLint plugin
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 8, 2021

CLA Signed

The committers are authorized under a signed CLA.

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Oct 8, 2021
@eslint-github-bot
Copy link

eslint-github-bot bot commented Oct 8, 2021

Hi @xiaohp!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM, thanks!

@aladdin-add aladdin-add added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Oct 8, 2021
@aladdin-add
Copy link
Member

aladdin-add commented Oct 8, 2021

@xiaohp can you sign the cla please?

@xiaohp
Copy link
Contributor Author

xiaohp commented Oct 8, 2021

@xiaohp can you sign the cla please?

just signed, thanks!

nzakas
nzakas approved these changes Oct 9, 2021
Copy link
Member

@nzakas nzakas left a comment

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants