feat: move eslint --init to @eslint/create-config

[aladdin-add]

TODOs:

• Update: rm eslint auto config. rfc step 1

• Update: mv eslint --init to another package. step 2

• move to esm.

• fix failing tests

• move to the eslint/create-config repo

• docs update

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

fixes #14768

Is there anything you'd like reviewers to focus on?

[mdjermanovic]

I think the files should be copied to the new repo https://github.com/eslint/create-config, as we decided not to go in the monorepo direction for this.

[aladdin-add]

absolutely right -- that's why the PR is a draft, will do later. 😄

[aladdin-add]

update: I was planning to move proxyrequire to testdouble in eslint/create-config, as proxyrequire does not support esm mocking.

[nzakas]

What’s the status on this? We are getting a bunch of issues/PRs related to —init and we need to make some progress.

[aladdin-add]

Now I'm using the native Node.js esm as sindresorhus' blog (not pushed yet):

• Add "type": "module", to package.json (below the author field)
• Add "exports": "./index.js", to package.json (below the type field)
• Update engines field in package.json to Node.js 12.
• Update index.d.ts to use ESM imports/exports.
• Update code examples in readme and index.d.ts to use ESM and also top-level await.
• Remove 'use strict';.
• Convert '.' to './index.js'.
• Use the node: protocol for imports.

additionally, I replaced proxyquire to testdouble(as proxyquire does not support esm mocking).

does it make sense? Do we want to add the cjs export in the new package, too?

[mdjermanovic]

• Add "exports": "./index.js", to package.json (below the type field)
  Do we want to add the cjs export in the new package, too?

Do we want to export anything from this package? If it's meant to be only a CLI app, I think we can publish ESM-only package, without exports.

[nzakas]

I agree. I don’t think we need to export anything.

[nzakas]

Where are we on this? Is there a reason all the work is being done here instead of on the new repo?

[aladdin-add]

this is ready for review, but set to a draft to make sure we don't merge it before @eslint/create-config is released.

[btmills]

I was able to test this manually locally with this setup:

1. In my eslint/create-config checkout, npm link.
2. In my eslint/eslint checkout on this branch, npm link @eslint/create-config.
3. In my eslint/eslint checkout on this branch, npx eslint --init.

[btmills]

LGTM, thanks! Leaving as comment instead of approval pending release of @eslint/create-config.

[eslint-github-bot]

Hi @aladdin-add!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

[nzakas]

Where are we on this? What’s needed now?

[aladdin-add]

The only thing is: eslint/create-config#10.

Given npx will always use latest, seems this one can even be merged first.

[nzakas]

Okay, just releases v0.1.2. See my note on the issue about the version number.

[mdjermanovic]

Should we keep unit tests for the config-rule.js module?

[mdjermanovic]

Can we delete tests/fixtures/autoconfig/*?

[aladdin-add]

@mdjermanovic should be addressed now. 😄

[btmills]

LGTM! Leaving open to allow others to follow up their reviews.

[mdjermanovic]

LGTM, thanks!