Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: @eslint/eslintrc@1.0.3 for Jest workaround #15164

Merged
merged 2 commits into from Oct 14, 2021

Conversation

btmills
Copy link
Member

@btmills btmills commented Oct 14, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: dependency upgrade

What changes did you make? (Give an overview)

I just published @eslint/eslintrc@1.0.3, which contains eslint/eslintrc#57. It adds a workaround for Jest, which doesn’t support exports in package.json.

Is there anything you'd like reviewers to focus on?

@btmills btmills added accepted There is consensus among the team that this change meets the criteria for inclusion upgrade This change is related to a dependency upgrade labels Oct 14, 2021
`eslint-plugin-node`'s `no-missing-require` previously had a false
positive report that the `@eslint/eslintrc/universal` export did not
exist. Now with the release of `@eslint/eslintrc@1.0.3` with a "fake"
(not part of `exports` in `package.json`) `universal` export, as a
workaround for Jest, `no-missing-require` is satisfied that it does
exist.
@btmills btmills merged commit f9217e5 into master Oct 14, 2021
13 checks passed
@btmills btmills deleted the eslintrc-jest-workaround branch Oct 14, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Apr 13, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion upgrade This change is related to a dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant