Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow baseConfig to extend preloaded plugin config (fixes #15079)

Merged
merged 2 commits into from Oct 22, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 19, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #15079

What changes did you make? (Give an overview)

  • Fixed the issue by adding a new option preloadedPlugins to the CLIEngine constructor.
  • Removed CLIEngine#addPlugin() and updated CLIEngine tests to use the new option. This was to additionally check that this change doesn't break something, in the case that some of those tests were not copied to ESLint class tests.
  • Fixed JSDoc for the ESLint constructor option plugins, it isn't an array.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug core accepted labels Oct 19, 2021
nzakas
nzakas approved these changes Oct 20, 2021
Copy link
Member

@nzakas nzakas left a comment

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age bug core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants