Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix counting of files in performance test #15190

Merged
merged 1 commit into from Oct 21, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 20, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Fixes counting of files in the multi-files performance test.

The test works good, it lints 450 files, but the message shows zero.

Multi Files (0 files):

What changes did you make? (Give an overview)

  • Path is relative, so it shouldn't slice off C: on Windows (I guess that was the intention).
  • The pattern is prepared with quotes, and that's good for a command-line argument, but those quotes should be removed for glob.sync().

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants