Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update no-inner-declarations for class static blocks #15290

merged 1 commit into from Nov 21, 2021


Copy link

@mdjermanovic mdjermanovic commented Nov 11, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Refs #15016, fixes no-inner-declarations.

What changes did you make? (Give an overview)

Updated the no-inner-declarations rule to allow declarations at the top level of class static blocks.

/* eslint no-inner-declarations: ["error", "both"] */

class C {
    method() {
        function f() {} // ok
        var x; // ok
    static {
        function f() {} // should be ok, too
        var x; // should be ok, too

Is there anything you'd like reviewers to focus on?

Updates the `no-inner-declarations` rule to allow declarations at the top level of class static blocks.

Refs #15016
@btmills btmills merged commit de69cec into main Nov 21, 2021
14 checks passed
@btmills btmills deleted the staticblocks-noinnerdeclarations branch Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants