Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update no-invalid-this and no-eval for class static blocks #15300

Merged
merged 1 commit into from Nov 15, 2021

Conversation

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Nov 12, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Refs #15016, fixes no-invalid-this and no-eval.

What changes did you make? (Give an overview)

Fixed false positives of rules no-invalid-this and no-eval in cases where this is used in class static blocks:

class C {
    static {
        this; // this isn't invalid `this`
    }

    static {
        this.eval(); // this isn't global `eval()`
    }
}

Is there anything you'd like reviewers to focus on?

Fixes false positives of rules `no-invalid-this` and `no-eval` in cases where `this` is used in class static blocks.

Refs #15016
Copy link
Contributor

@snitin315 snitin315 left a comment

LGTM

@mdjermanovic mdjermanovic merged commit 6d1c666 into main Nov 15, 2021
14 checks passed
@mdjermanovic mdjermanovic deleted the staticblocks-isdefaultthisbinding branch Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants