Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update semi-style for class static blocks #15309

Merged
merged 1 commit into from Nov 21, 2021
Merged

Conversation

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Nov 13, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Refs #15016, fixes semi-style.

What changes did you make? (Give an overview)

Fixed false positive in the semi-style rule: the last statement in a class static block should be allowed to have its semicolon on the same line when the option is "first".

/* eslint semi-style: ["error", "first"] */

if (foo) {  
    bar(); // allowed
}

class C {
    method() {
      bar(); // allowed
    }
  
    static {
      bar(); // should be allowed, too
    }
}

Is there anything you'd like reviewers to focus on?

Fixes false positive in the `semi-style` rule: the last statement in a class static block should be allowed to have its semicolon on the same line when the option is `first`.

Refs #15016
@btmills btmills merged commit 479a4cb into main Nov 21, 2021
14 checks passed
@btmills btmills deleted the staticblocks-semistyle branch Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants