Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused parameter in linter.js #15451

Merged
merged 1 commit into from Dec 25, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Dec 24, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Removes unused parameter filename from function getDirectiveComments in linter.js.

What changes did you make? (Give an overview)

Removed the unused parameter.

Is there anything you'd like reviewers to focus on?

It seems that filename was unused from the start (function getDirectiveComments was added in 558ccba).

no-unused-vars didn't report this because we have args: "after-used".

@mdjermanovic mdjermanovic added accepted chore labels Dec 24, 2021
Copy link
Contributor

@snitin315 snitin315 left a comment

LGTM

@aladdin-add aladdin-add merged commit 28e907a into main Dec 25, 2021
14 checks passed
@aladdin-add aladdin-add deleted the getdirectivecomments-unused-filename branch Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants