Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: false negative with property option in id-match #15474

Merged
merged 1 commit into from Jan 6, 2022

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Jan 1, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixes #15443

/* eslint id-match: ["error", "^[^a]"] */

const foo = {
 [a]: 1 // Error: Identifier 'a' does not match the pattern '^[^a]'
};

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added triage feature labels Jan 1, 2022
@mdjermanovic mdjermanovic added accepted bug rule and removed triage labels Jan 6, 2022
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 127f524 into main Jan 6, 2022
14 checks passed
@mdjermanovic mdjermanovic deleted the feat/id-match-false-negative branch Jan 6, 2022
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jul 6, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age label Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age bug feature rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants