Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add property fatalErrorCount to ignored file results #15520

Merged
merged 1 commit into from Jan 14, 2022
Merged

fix: Add property fatalErrorCount to ignored file results #15520

merged 1 commit into from Jan 14, 2022

Conversation

fasttime
Copy link
Contributor

@fasttime fasttime commented Jan 13, 2022

Fixes #15510

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Added property fatalErrorCount with value 0 to ignored file results
  • Added missing property fatalErrorCount to JSDoc for LintResult and LintReport
  • Updated unit tests that produce ignored file results to also check the number of fatal errors

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added triage bug labels Jan 13, 2022
@linux-foundation-easycla
Copy link

@linux-foundation-easycla linux-foundation-easycla bot commented Jan 13, 2022

CLA Signed

The committers are authorized under a signed CLA.

@fasttime fasttime marked this pull request as ready for review Jan 13, 2022
nzakas
nzakas approved these changes Jan 14, 2022
Copy link
Member

@nzakas nzakas left a comment

Nice work! Thanks for fixing this.

assert.strictEqual(report.fixableErrorCount, 0);
assert.strictEqual(report.fixableWarningCount, 0);
assert.strictEqual(report.results[0].errorCount, 0);
assert.strictEqual(report.results[0].warningCount, 1);
assert.strictEqual(report.fixableErrorCount, 0);
assert.strictEqual(report.fixableWarningCount, 0);
assert.strictEqual(report.results[0].fatalErrorCount, 0);
Copy link
Member

@nzakas nzakas Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@nzakas nzakas merged commit db15802 into eslint:main Jan 14, 2022
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants