Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed typo in comment #15531

Merged
merged 1 commit into from Jan 19, 2022
Merged

docs: Fixed typo in comment #15531

merged 1 commit into from Jan 19, 2022

Conversation

magua-io
Copy link
Contributor

@magua-io magua-io commented Jan 18, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Update typo in the comment.

Is there anything you'd like reviewers to focus on?

N/A

@eslint-github-bot eslint-github-bot bot added the triage label Jan 18, 2022
@linux-foundation-easycla
Copy link

@linux-foundation-easycla linux-foundation-easycla bot commented Jan 18, 2022

CLA Signed

The committers are authorized under a signed CLA.

@eslint-github-bot
Copy link

@eslint-github-bot eslint-github-bot bot commented Jan 18, 2022

Hi @magua-io!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@magua-io magua-io changed the title Fixed typo in comment docs: Fixed typo in comment Jan 18, 2022
@eslint-github-bot
Copy link

@eslint-github-bot eslint-github-bot bot commented Jan 18, 2022

Hi @magua-io!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@eslint-github-bot
Copy link

@eslint-github-bot eslint-github-bot bot commented Jan 18, 2022

Hi @magua-io!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

nzakas
nzakas approved these changes Jan 18, 2022
Copy link
Member

@nzakas nzakas left a comment

LGTM. Thanks!

Copy link
Contributor

@snitin315 snitin315 left a comment

LGTM, thank you for contributing.

@snitin315 snitin315 merged commit 851f1f1 into eslint:main Jan 19, 2022
12 of 13 checks passed
@snitin315 snitin315 added accepted documentation and removed triage labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants