-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
docs: add missed verb in no-ex-assign
rule
#15550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I'll close-reopen to see if that will fix the CLA check.
|
Okay, the check works now. @jmosawy can you please sign CLA, so we could merge this? |
@mdjermanovic It's done. ✅ |
Thanks for contributing! |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.8.0` -> `8.9.0`](https://renovatebot.com/diffs/npm/eslint/8.8.0/8.9.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.9.0`](https://github.com/eslint/eslint/releases/v8.9.0) [Compare Source](eslint/eslint@v8.8.0...v8.9.0) #### Features - [`68f64a9`](eslint/eslint@68f64a9) feat: update eslint-scope to ignore `"use strict"` directives in ES3 ([#​15595](eslint/eslint#15595)) (Milos Djermanovic) - [`db57639`](eslint/eslint@db57639) feat: add `es2016`, `es2018`, `es2019`, and `es2022` environments ([#​15587](eslint/eslint#15587)) (Milos Djermanovic) - [`2dc38aa`](eslint/eslint@2dc38aa) feat: fix bug with arrow function return types in function-paren-newline ([#​15541](eslint/eslint#15541)) (Milos Djermanovic) - [`6f940c3`](eslint/eslint@6f940c3) feat: Implement FlatRuleTester ([#​15519](eslint/eslint#15519)) (Nicholas C. Zakas) #### Documentation - [`570a036`](eslint/eslint@570a036) docs: add `one-var` example with `for-loop` initializer ([#​15596](eslint/eslint#15596)) (Milos Djermanovic) - [`417191d`](eslint/eslint@417191d) docs: Remove the $ prefix in terminal commands ([#​15565](eslint/eslint#15565)) (Andreas Lewis) - [`389ff34`](eslint/eslint@389ff34) docs: add missing `Variable#scope` property in the scope manager docs ([#​15571](eslint/eslint#15571)) (Milos Djermanovic) - [`f63795d`](eslint/eslint@f63795d) docs: no-eval replace dead link with working one ([#​15568](eslint/eslint#15568)) (rasenplanscher) - [`0383591`](eslint/eslint@0383591) docs: Remove old Markdown issue template ([#​15556](eslint/eslint#15556)) (Brandon Mills) - [`a8dd5a2`](eslint/eslint@a8dd5a2) docs: add 'when not to use it' section in no-duplicate-case docs ([#​15563](eslint/eslint#15563)) (Milos Djermanovic) - [`1ad439e`](eslint/eslint@1ad439e) docs: add missed verb in docs ([#​15550](eslint/eslint#15550)) (Jeff Mosawy) #### Chores - [`586d45c`](eslint/eslint@586d45c) chore: Upgrade to espree@9.3.1 ([#​15600](eslint/eslint#15600)) (Milos Djermanovic) - [`623e1e2`](eslint/eslint@623e1e2) chore: Upgrade to eslint-visitor-keys@3.3.0 ([#​15599](eslint/eslint#15599)) (Milos Djermanovic) - [`355b23d`](eslint/eslint@355b23d) chore: fix outdated link to Code of Conduct in PR template ([#​15578](eslint/eslint#15578)) (Rich Trott) - [`b10fef2`](eslint/eslint@b10fef2) ci: use Node 16 for browser test ([#​15569](eslint/eslint#15569)) (Milos Djermanovic) - [`92f89fb`](eslint/eslint@92f89fb) chore: suggest demo link in bug report template ([#​15557](eslint/eslint#15557)) (Brandon Mills) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1173 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
I spotted the verb
is
is missed in the no-ex-assign rule's doc, so I just wanted to update this one.Is there anything you'd like reviewers to focus on?