Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add onlyOneSimpleParam option to no-confusing-arrow rule #15566

Merged
merged 7 commits into from Feb 18, 2022

Conversation

Gautam-Arora24
Copy link
Contributor

@Gautam-Arora24 Gautam-Arora24 commented Feb 2, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added onlyOneSimpleParam option in the no-confusing-arrow rule which when set to true, will warn if an arrow function is used with one single parameter(either primitive or identifier literal).

Is there anything you'd like reviewers to focus on?

Open for the feedback :)

Fixes: #15548

@eslint-github-bot eslint-github-bot bot added triage An ESLint team member will look at this issue soon feature This change adds a new feature to ESLint labels Feb 2, 2022
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Feb 2, 2022
lib/rules/no-confusing-arrow.js Outdated Show resolved Hide resolved
lib/rules/no-confusing-arrow.js Outdated Show resolved Hide resolved
tests/lib/rules/no-confusing-arrow.js Outdated Show resolved Hide resolved
@Gautam-Arora24 Gautam-Arora24 requested a review from mdjermanovic Feb 3, 2022
@mdjermanovic mdjermanovic changed the title feat: Add option to no-confusing-arrow rule feat: Add onlyOneSimpleParam option to no-confusing-arrow rule Feb 3, 2022
docs/rules/no-confusing-arrow.md Outdated Show resolved Hide resolved
docs/rules/no-confusing-arrow.md Outdated Show resolved Hide resolved
@nzakas
Copy link
Member

nzakas commented Feb 10, 2022

@Gautam-Arora24 are you still working on this?

@Gautam-Arora24
Copy link
Contributor Author

Gautam-Arora24 commented Feb 10, 2022

Yes @nzakas Creating a follow up commit today :)

docs/rules/no-confusing-arrow.md Outdated Show resolved Hide resolved
docs/rules/no-confusing-arrow.md Outdated Show resolved Hide resolved
docs/rules/no-confusing-arrow.md Show resolved Hide resolved
docs/rules/no-confusing-arrow.md Outdated Show resolved Hide resolved
docs/rules/no-confusing-arrow.md Show resolved Hide resolved
docs/rules/no-confusing-arrow.md Outdated Show resolved Hide resolved
docs/rules/no-confusing-arrow.md Outdated Show resolved Hide resolved
docs/rules/no-confusing-arrow.md Outdated Show resolved Hide resolved
docs/rules/no-confusing-arrow.md Show resolved Hide resolved
docs/rules/no-confusing-arrow.md Outdated Show resolved Hide resolved
nzakas
nzakas approved these changes Feb 17, 2022
Copy link
Member

@nzakas nzakas left a comment

Overall looks good. Just one suggestion.

lib/rules/no-confusing-arrow.js Outdated Show resolved Hide resolved
docs/rules/no-confusing-arrow.md Outdated Show resolved Hide resolved
nzakas
nzakas approved these changes Feb 18, 2022
Copy link
Member

@nzakas nzakas left a comment

LGTM

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 345e70d into eslint:main Feb 18, 2022
14 checks passed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 8, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.9.0` -> `8.10.0`](https://renovatebot.com/diffs/npm/eslint/8.9.0/8.10.0) |

---

### Release Notes

<details>
<summary>eslint/eslint</summary>

### [`v8.10.0`](https://github.com/eslint/eslint/releases/v8.10.0)

[Compare Source](eslint/eslint@v8.9.0...v8.10.0)

#### Features

-   [`6e2c325`](eslint/eslint@6e2c325) feat: Add `ignoreOnInitialization` option to no-shadow rule ([#&#8203;14963](eslint/eslint#14963)) (Soufiane Boutahlil)
-   [`115cae5`](eslint/eslint@115cae5) feat: `--debug` prints time it takes to parse a file ([#&#8203;15609](eslint/eslint#15609)) (Bartek Iwańczuk)
-   [`345e70d`](eslint/eslint@345e70d) feat: Add `onlyOneSimpleParam` option to no-confusing-arrow rule ([#&#8203;15566](eslint/eslint#15566)) (Gautam Arora)

#### Bug Fixes

-   [`cdc5802`](eslint/eslint@cdc5802) fix: Avoid `__dirname` for built-in configs ([#&#8203;15616](eslint/eslint#15616)) (DoZerg)
-   [`ee7c5d1`](eslint/eslint@ee7c5d1) fix: false positive in `camelcase` with combined properties ([#&#8203;15581](eslint/eslint#15581)) (Nitin Kumar)

#### Documentation

-   [`1005bd5`](eslint/eslint@1005bd5) docs: update CLA information ([#&#8203;15630](eslint/eslint#15630)) (Nitin Kumar)
-   [`5d65c3b`](eslint/eslint@5d65c3b) docs: Fix typo in `no-irregular-whitespace` ([#&#8203;15634](eslint/eslint#15634)) (Ryota Sekiya)
-   [`b93af98`](eslint/eslint@b93af98) docs: add links between rules about whitespace around block curly braces ([#&#8203;15625](eslint/eslint#15625)) (Milos Djermanovic)
-   [`ebc0460`](eslint/eslint@ebc0460) docs: update babel links ([#&#8203;15624](eslint/eslint#15624)) (Milos Djermanovic)

#### Chores

-   [`7cec74e`](eslint/eslint@7cec74e) chore: upgrade [@&#8203;eslint/eslintrc](https://github.com/eslint/eslintrc)[@&#8203;1](https://github.com/1).2.0 ([#&#8203;15648](eslint/eslint#15648)) (Milos Djermanovic)
-   [`11c8580`](eslint/eslint@11c8580) chore: read `ESLINT_MOCHA_TIMEOUT` env var in Makefile.js ([#&#8203;15626](eslint/eslint#15626)) (Piggy)
-   [`bfaa548`](eslint/eslint@bfaa548) test: add integration tests with built-in configs ([#&#8203;15612](eslint/eslint#15612)) (Milos Djermanovic)
-   [`39a2fb3`](eslint/eslint@39a2fb3) perf: fix lazy loading of core rules ([#&#8203;15606](eslint/eslint#15606)) (Milos Djermanovic)
-   [`3fc9196`](eslint/eslint@3fc9196) chore: include `tests/conf` in test runs ([#&#8203;15610](eslint/eslint#15610)) (Milos Djermanovic)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1190
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
srijan-deepsource pushed a commit to deepsourcelabs/eslint that referenced this pull request May 30, 2022
…int#15566)

* feat: Add  option to no-confusing-arrow rule

* Follow up commit

* Another follow up commit

* Another follow up commit

* Another commit

* Another followup commit

* Final Commit
srijan-deepsource added a commit to deepsourcelabs/eslint that referenced this pull request May 30, 2022
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Aug 18, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 18, 2022
@Gautam-Arora24 Gautam-Arora24 deleted the pr-15548 branch Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Change: Add onlyOneSimpleParam: boolean option to no-confusing-arrow
3 participants