chore: remove useless additionalItems: false from padding-line-between-statements schema
#15706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
triage
|
|
mdjermanovic
added
rule
mdjermanovic
changed the title
mdjermanovic
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
LGTM, thanks!
This is a non-breaking change because those two additionalItems: false were just ignored. Validation works the same with and without them. For clarity, ESLint uses Ajv 6 without strict checks, so this error doesn't appear anywhere. Still, additionalItems: false is indeed useless when the array is not a tuple, so it's better to remove it to avoid confusion about the intent.
mdjermanovic
changed the title
additionalItems: false from padding-line-between-statements schema
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 27, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.11.0` -> `8.12.0`](https://renovatebot.com/diffs/npm/eslint/8.11.0/8.12.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.12.0`](https://github.com/eslint/eslint/releases/v8.12.0) [Compare Source](eslint/eslint@v8.11.0...v8.12.0) #### Features - [`685a67a`](eslint/eslint@685a67a) feat: fix logic for top-level `this` in no-invalid-this and no-eval ([#​15712](eslint/eslint#15712)) (Milos Djermanovic) #### Chores - [`18f5e05`](eslint/eslint@18f5e05) chore: padding-line-between-statements remove useless `additionalItems` ([#​15706](eslint/eslint#15706)) (Martin Sadovy) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1256 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
srijan-deepsource
pushed a commit
to DeepSourceCorp/eslint
that referenced
this pull request
May 30, 2022
srijan-deepsource
added a commit
to DeepSourceCorp/eslint
that referenced
this pull request
May 30, 2022
…onalItems` (eslint#15706)" This reverts commit ff58798.
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment:
What changes did you make? (Give an overview)
If you run AJV in strict mode, you will get error:
see https://github.com/ajv-validator/ajv/blob/master/docs/json-schema.md
Note: Many another rule schemas are not 100% valid in strict mode. This is just one of them.