feat: `array-callback-return` support `findLast` and `findLastIndex` #16314

sosukesuzuki · 2022-09-15T16:56:02Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixes #16313

Support Stage 4 Array.prototype.findLast and Array.prototype.findLastIndex of array-callback-return

Is there anything you'd like reviewers to focus on?

netlify · 2022-09-15T16:56:07Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`cae3ff7`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/6323b6473412250008eeffd3
😎 Deploy Preview	https://deploy-preview-16314--docs-eslint.netlify.app/rules/array-callback-return
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

eslint-github-bot · 2022-09-15T16:56:07Z

Hi @sosukesuzuki!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

linux-foundation-easycla · 2022-09-15T16:56:07Z

The committers listed above are authorized under a signed CLA.

✅ login: sosukesuzuki / name: Sosuke Suzuki (329ed97)

Fixes eslint#16313

mdjermanovic

Thanks for the PR!

Code looks good. Can you also update documentation for this rule?

eslint-github-bot · 2022-09-15T23:33:30Z

Hi @sosukesuzuki!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

sosukesuzuki · 2022-09-15T23:37:08Z

docs/src/rules/array-callback-return.md

+* [`Array.prototype.findLast`](https://tc39.es/ecma262/#sec-array.prototype.findlast)
+* [`Array.prototype.findLastIndex`](https://tc39.es/ecma262/#sec-array.prototype.findlastindex)


These features will be landed in ES2023, but it haven't been published to www.ecma-international.org/ecma-262 yet so I think we should link to tc39.es/ecma262 for now.

Since the spec is a living standard, and by the time anything lands on ecma's website it's obsolete, all the links should really be to tc39.es anyways.

mdjermanovic

LGTM, thanks!

I'll leave this open for a few days in case someone else wants to review it before merging.

snitin315

LGTM, thanks!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.23.1` -> `8.24.0`](https://renovatebot.com/diffs/npm/eslint/8.23.1/8.24.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.24.0`](https://github.com/eslint/eslint/releases/tag/v8.24.0) [Compare Source](eslint/eslint@v8.23.1...v8.24.0) #### Features - [`1729f9e`](eslint/eslint@1729f9e) feat: account for `sourceType: "commonjs"` in the strict rule ([#16308](eslint/eslint#16308)) (Milos Djermanovic) - [`b0d72c9`](eslint/eslint@b0d72c9) feat: add rule logical-assignment-operators ([#16102](eslint/eslint#16102)) (fnx) - [`f02bcd9`](eslint/eslint@f02bcd9) feat: `array-callback-return` support `findLast` and `findLastIndex` ([#16314](eslint/eslint#16314)) (Sosuke Suzuki) #### Documentation - [`2c152ff`](eslint/eslint@2c152ff) docs: note false positive `Object.getOwnPropertyNames` in prefer-reflect ([#16317](eslint/eslint#16317)) (AnnAngela) - [`bf7bd88`](eslint/eslint@bf7bd88) docs: fix warn severity description for new config files ([#16324](eslint/eslint#16324)) (Nitin Kumar) - [`8cc0bbe`](eslint/eslint@8cc0bbe) docs: use more clean link syntax ([#16309](eslint/eslint#16309)) (Percy Ma) - [`6ba269e`](eslint/eslint@6ba269e) docs: fix typo ([#16288](eslint/eslint#16288)) (jjangga0214) #### Chores - [`131e646`](eslint/eslint@131e646) chore: Upgrade [@humanwhocodes/config-array](https://github.com/humanwhocodes/config-array) for perf ([#16339](eslint/eslint#16339)) (Nicholas C. Zakas) - [`504fe59`](eslint/eslint@504fe59) perf: switch from object spread to `Object.assign` when merging globals ([#16311](eslint/eslint#16311)) (Milos Djermanovic) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1560 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Sep 15, 2022

feat: support Array.prototype.find(Last)Index.

4b73e8d

Fixes eslint#16313

sosukesuzuki force-pushed the add-find-last branch from 329ed97 to 4b73e8d Compare September 15, 2022 17:00

eslint-github-bot bot added the feature This change adds a new feature to ESLint label Sep 15, 2022

mdjermanovic added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Sep 15, 2022

mdjermanovic requested changes Sep 15, 2022

View reviewed changes

docs: update array-callback-return docs

cae3ff7

sosukesuzuki commented Sep 15, 2022

View reviewed changes

sosukesuzuki changed the title ~~feat: array-callback-return support Array.prototype.findLast and Array.prototype.findLastIndex~~ feat: array-callback-return support findLast and findLastIndex Sep 15, 2022

mdjermanovic approved these changes Sep 16, 2022

View reviewed changes

snitin315 approved these changes Sep 16, 2022

View reviewed changes

snitin315 merged commit f02bcd9 into eslint:main Sep 16, 2022

sosukesuzuki deleted the add-find-last branch September 16, 2022 14:49

mdjermanovic added the contributor pool label Sep 16, 2022

moul-bot mentioned this pull request Sep 26, 2022

chore(deps-dev): bump eslint from 7.32.0 to 8.24.0 in /js berty/berty#4439

Closed

sync-by-unito bot mentioned this pull request Oct 10, 2022

build(deps-dev): bump eslint from 8.20.0 to 8.25.0 SmartTokenLabs/token-negotiator#420

Merged

moul-bot mentioned this pull request Oct 10, 2022

chore(deps-dev): bump eslint from 7.32.0 to 8.25.0 in /js berty/berty#4459

Closed

eslint-github-bot bot locked and limited conversation to collaborators Mar 16, 2023

eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: `array-callback-return` support `findLast` and `findLastIndex` #16314

feat: `array-callback-return` support `findLast` and `findLastIndex` #16314

sosukesuzuki commented Sep 15, 2022

netlify bot commented Sep 15, 2022 •

edited

Loading

eslint-github-bot bot commented Sep 15, 2022

linux-foundation-easycla bot commented Sep 15, 2022 •

edited

Loading

mdjermanovic left a comment

eslint-github-bot bot commented Sep 15, 2022

sosukesuzuki Sep 15, 2022

ljharb Sep 16, 2022

mdjermanovic left a comment

snitin315 left a comment

		* [`Array.prototype.findLast`](https://tc39.es/ecma262/#sec-array.prototype.findlast)
		* [`Array.prototype.findLastIndex`](https://tc39.es/ecma262/#sec-array.prototype.findlastindex)

feat: array-callback-return support findLast and findLastIndex #16314

feat: array-callback-return support findLast and findLastIndex #16314

Conversation

sosukesuzuki commented Sep 15, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

netlify bot commented Sep 15, 2022 • edited Loading

✅ Deploy Preview for docs-eslint ready!

eslint-github-bot bot commented Sep 15, 2022

linux-foundation-easycla bot commented Sep 15, 2022 • edited Loading

mdjermanovic left a comment

Choose a reason for hiding this comment

eslint-github-bot bot commented Sep 15, 2022

sosukesuzuki Sep 15, 2022

Choose a reason for hiding this comment

ljharb Sep 16, 2022

Choose a reason for hiding this comment

mdjermanovic left a comment

Choose a reason for hiding this comment

snitin315 left a comment

Choose a reason for hiding this comment

feat: `array-callback-return` support `findLast` and `findLastIndex` #16314

feat: `array-callback-return` support `findLast` and `findLastIndex` #16314

netlify bot commented Sep 15, 2022 •

edited

Loading

linux-foundation-easycla bot commented Sep 15, 2022 •

edited

Loading