chore: Upgrade @humanwhocodes/config-array for perf

[nzakas]

Latest version of the package includes more aggressive caching.

Fixes #16302

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Upgraded dependency

What changes did you make? (Give an overview)

I upgraded @humanwhocodes/config-array to the latest version. This includes a caching change to cache by matching indices, similar to what eslintrc does. In theory this should improve runtime performance, although running it with npm run perf didn't actually seem to improve the numbers, and in fact, may have made them worse. 🤷

Before:

Single File:
  CPU Speed is 2304 with multiplier 13000000
  Performance Run #1:  6113.9516ms
  Performance Run #2:  6133.3029ms
  Performance Run #3:  6176.0898ms
  Performance Run #4:  5952.241ms
  Performance Run #5:  5964.2055ms

  Performance budget exceeded: 6113.9516ms (limit: 5642.361111111111ms)


Multi Files (450 files):
  CPU Speed is 2304 with multiplier 39000000
  Performance Run #1:  15021.9307ms
  Performance Run #2:  17540.9971ms
  Performance Run #3:  17162.8673ms
  Performance Run #4:  16508.3412ms
  Performance Run #5:  17846.8817ms

  Performance budget exceeded: 17162.8673ms (limit: 16927.083333333332ms)

After:

Single File:
  CPU Speed is 2304 with multiplier 13000000
  Performance Run #1:  6251.8269ms
  Performance Run #2:  6340.695ms
  Performance Run #3:  6383.4306ms
  Performance Run #4:  6483.3105ms
  Performance Run #5:  8135.5252ms

  Performance budget exceeded: 6383.4306ms (limit: 5642.361111111111ms)


Multi Files (450 files):
  CPU Speed is 2304 with multiplier 39000000
  Performance Run #1:  18660.2942ms
  Performance Run #2:  19920.5086ms
  Performance Run #3:  21486.0697ms
  Performance Run #4:  18835.6062ms
  Performance Run #5:  19494.3152ms

  Performance budget exceeded: 19494.3152ms (limit: 16927.083333333332ms)

Is there anything you'd like reviewers to focus on?

Please double-check that config-array changes to see if they are actually matching the eslintrc behavior.

[netlify]

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	c6eff5a
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/632b79962970da000881d52e

[mdjermanovic]

In theory this should improve runtime performance, although running it with npm run perf didn't actually seem to improve the numbers, and in fact, may have made them worse.

I'm getting better multi-file performance after the change.

Before (with @humanwhocodes/config-array v0.10.4):

Single File:
  CPU Speed is 2695 with multiplier 13000000
  Performance Run #1:  4864.1887ms
  Performance Run #2:  5338.3667ms
  Performance Run #3:  4875.3077ms
  Performance Run #4:  4863.727ms
  Performance Run #5:  4853.5706ms

  Performance budget exceeded: 4864.1887ms (limit: 4823.747680890538ms)


Multi Files (450 files):
  CPU Speed is 2695 with multiplier 39000000
  Performance Run #1:  12755.044ms
  Performance Run #2:  12391.5217ms
  Performance Run #3:  12405.5728ms
  Performance Run #4:  12359.3816ms
  Performance Run #5:  12362.7924ms

  Performance budget ok:  12391.5217ms (limit: 14471.243042671615ms)

After (with @humanwhocodes/config-array v0.10.5):

Single File:
  CPU Speed is 2695 with multiplier 13000000
  Performance Run #1:  4838.7403ms
  Performance Run #2:  4860.4875ms
  Performance Run #3:  4855.6663ms
  Performance Run #4:  4855.972ms
  Performance Run #5:  4869.1903ms

  Performance budget exceeded: 4855.972ms (limit: 4823.747680890538ms)


Multi Files (450 files):
  CPU Speed is 2695 with multiplier 39000000
  Performance Run #1:  11789.7996ms
  Performance Run #2:  12446.8747ms
  Performance Run #3:  11818.3672ms
  Performance Run #4:  11874.392100000001ms
  Performance Run #5:  12008.8462ms

  Performance budget ok:  11874.392100000001ms (limit: 14471.243042671615ms)

Our perf test config is much simpler than the config in #16302 so the numbers don't show how big the improvement really is. I don't see anything in humanwhocodes/config-array@8a7e8ab that could cause worse numbers.

[mdjermanovic]

Please double-check that config-array changes to see if they are actually matching the eslintrc behavior

LGTM!

Some possible further improvements:

• eslintrc uses Minimatch class and keeps its instances, so each pattern is processed only once. The new config array uses minimatch function, which will repeat the new Minimatch step every time.
• For ignored files, the config value stored in the cache is undefined, but this code will interpret it as a cache miss.