/ eslint Public
ci: fix npm v9 problem with
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
On the recently released Node v19.3.0, we're getting a lot of errors related to loading
eslint-plugin-internal-rules, which is in our package.json specified as
"eslint-plugin-internal-rules": "file:tools/internal-rules". Node v19.3.0 is the first version that includes npm v9, and the cause of the problem seems to be the new default value
truefor the option
What changes did you make? (Give an overview)
.npmrc, I added
install-links = falseto restore pre-v9 npm behavior.
Is there anything you'd like reviewers to focus on?
I'm not sure why exactly it doesn't work with the default
install-links = true.