Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: indent rule does not indent when doing multi-line chain calls #3502

Merged
merged 1 commit into from Aug 24, 2015

Conversation

BYK
Copy link
Member

@BYK BYK commented Aug 24, 2015

Fixes #3279

@gyandeeps
Copy link
Member

Excellent Excellent Excellent ... 🎉
I actually started looking into this but was going in a different direction. Specially when I saw we calculate the function body indent based on the first element in body. 😨

@BYK
Copy link
Member Author

BYK commented Aug 24, 2015

Specially when I saw we calculate the function body indent based on the first element in body. 😨

That was the reason why it was passing with non-empty function bodies before. It was masking this bug! :)

@nzakas
Copy link
Member

nzakas commented Aug 24, 2015

LGTM

nzakas added a commit that referenced this pull request Aug 24, 2015
Fix: `indent` rule does not indent when doing multi-line chain calls
@nzakas nzakas merged commit c4ab2de into master Aug 24, 2015
@ilyavolodin ilyavolodin deleted the issue-3279 branch August 25, 2015 00:54
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants