Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove path analysis from debug log (fixes #4631) #4726

Merged
merged 1 commit into from Dec 19, 2015
Merged

Conversation

ilyavolodin
Copy link
Member

I didn't remove any of the logging, I just changed debug command to not include code-path logs. This way, people can still get path analysis logs by running DEBUG=eslint:*

@nzakas
Copy link
Member

nzakas commented Dec 17, 2015

I don't think we want to just eliminate all code path messages. We should still have some basic logs coming from that module, just not so many.

@ilyavolodin
Copy link
Member Author

Well, the logs are not eliminated, they are just removed from --debug flag. You can still access them by doing DEBUG=eslint:* from the command line. I looked through the path analysis logging and all we log is enter/leave code path. I don't see how this might help end-user debug an issue, this is only helpful for rule developers, and they still have work-around to get to the logs.
Problem with logging less is I could remove logging for enter/leave, and only leave DOT logs, but they are pretty massive even on their own, more then that, they are not human readable (since they are meant to generate graphs through graphviz. If I remove DOT logs, and leave enter/leave then every node in AST will be logged.

@nzakas
Copy link
Member

nzakas commented Dec 18, 2015

Hmmmm ok. @mysticatea do you agree?

@mysticatea
Copy link
Member

I'm OK.
I'm sorry about many logs.

nzakas added a commit that referenced this pull request Dec 19, 2015
Fix: Remove path analysis from debug log (fixes #4631)
@nzakas nzakas merged commit e0c28d8 into master Dec 19, 2015
@alberto alberto deleted the issue-4631 branch January 6, 2016 23:56
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants