New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: `no-extra-parens` to check for nulls (fixes #6161) #6164

Merged
merged 1 commit into from May 14, 2016

Conversation

Projects
None yet
7 participants
@gyandeeps
Member

gyandeeps commented May 14, 2016

No description provided.

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented May 14, 2016

LGTM

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 14, 2016

By analyzing the blame information on this pull request, we identified @kaicataldo, @vitorbal and @michaelficarra to be potential reviewers

mention-bot commented May 14, 2016

By analyzing the blame information on this pull request, we identified @kaicataldo, @vitorbal and @michaelficarra to be potential reviewers

@alberto

This comment has been minimized.

Show comment
Hide comment
@alberto

alberto May 14, 2016

Member

Commit message should say no-extra-parens

Member

alberto commented May 14, 2016

Commit message should say no-extra-parens

@alberto

This comment has been minimized.

Show comment
Hide comment
@alberto

alberto May 14, 2016

Member

Other than that, LGTM

Member

alberto commented May 14, 2016

Other than that, LGTM

@mysticatea

This comment has been minimized.

Show comment
Hide comment
@mysticatea

mysticatea May 14, 2016

Member

LGTM except commit message :)

Member

mysticatea commented May 14, 2016

LGTM except commit message :)

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented May 14, 2016

LGTM

@gyandeeps gyandeeps changed the title from Fix: `no-extra-assign` to check for nulls (fixes #6161) to Fix: `no-extra-aparens` to check for nulls (fixes #6161) May 14, 2016

@gyandeeps gyandeeps changed the title from Fix: `no-extra-aparens` to check for nulls (fixes #6161) to Fix: `no-extra-parens` to check for nulls (fixes #6161) May 14, 2016

@ilyavolodin ilyavolodin merged commit f9ca0d6 into master May 14, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jQuery Foundation CLA All authors have signed the CLA
Details

@gyandeeps gyandeeps deleted the issue6161 branch May 14, 2016

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.