Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow semi as braceless body of statements (fixes #6386) #6391

Merged
merged 1 commit into from Jun 13, 2016

Conversation

Projects
None yet
7 participants
@alberto
Copy link
Member

commented Jun 12, 2016

No description provided.

@eslintbot

This comment has been minimized.

Copy link

commented Jun 12, 2016

LGTM

@mention-bot

This comment has been minimized.

Copy link

commented Jun 12, 2016

By analyzing the blame information on this pull request, we identified @vitorbal, @gyandeeps and @nzakas to be potential reviewers

@platinumazure

This comment has been minimized.

Copy link
Member

commented Jun 12, 2016

I missed the discussion- why avoid flagging the semicolon, rather than just avoiding a bad auto-fix?

@ilyavolodin

This comment has been minimized.

Copy link
Member

commented Jun 12, 2016

@platinumazure Cause if IfStatement doesn't have body, semi is required. And we are currently flagging it as extra.

@platinumazure

This comment has been minimized.

Copy link
Member

commented Jun 12, 2016

Ah, right. For some reason I thought we were recommending the use of empty
blocks there- thanks for the clarification.
On Jun 12, 2016 9:56 AM, "Ilya Volodin" notifications@github.com wrote:

@platinumazure https://github.com/platinumazure Cause if IfStatement
doesn't have body, semi is required. And we are currently flagging it as
extra.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6391 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AARWekAF4ZZfXeQJJrhX-mlt6tVk5JkMks5qLB44gaJpZM4Izvg_
.

@mysticatea

This comment has been minimized.

Copy link
Member

commented Jun 12, 2016

Thank you @alberto !

I'd like to fix similar issues in this, I guess WithStatement and LabelledStatement have the same problem.

@alberto

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2016

Makes sense. I'll add those too.

@alberto alberto force-pushed the issue6386 branch from 5dcadb3 to 46614fb Jun 13, 2016

@eslintbot

This comment has been minimized.

Copy link

commented Jun 13, 2016

LGTM

@alberto alberto changed the title Fix: allow semi in empty body of if statements (fixes #6386) Fix: allow semi as braceless body of statements (fixes #6386) Jun 13, 2016

@mysticatea

This comment has been minimized.

Copy link
Member

commented Jun 13, 2016

LGTM, thank you!

@ilyavolodin ilyavolodin merged commit cfdd524 into master Jun 13, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jQuery Foundation CLA All authors have signed the CLA
Details

@alberto alberto deleted the issue6386 branch Jun 13, 2016

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.