Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update peerDependencies of airbnb option for `--init` (fixes #6843) #6846

Merged
merged 1 commit into from Aug 5, 2016

Conversation

Projects
None yet
5 participants
@vitorbal
Copy link
Member

commented Aug 5, 2016

What issue does this pull request address?
#6843 Updates the peerDependencies of eslint-config-airbnb for the --init option.

What changes did you make? (Give an overview)
Updated the array of plugins to include the new peerDependencies.

Is there anything you'd like reviewers to focus on?
Nothing in particular. As mentioned in #6843 (comment), I kept this short and to the point.
I propose we discuss having an automated way of keeping these in sync on a separate issue, if need be.

@mention-bot

This comment has been minimized.

Copy link

commented Aug 5, 2016

@vitorbal, thanks for your PR! By analyzing the annotation information on this pull request, we identified @mysticatea, @kaicataldo and @IanVS to be potential reviewers

@eslintbot

This comment has been minimized.

Copy link

commented Aug 5, 2016

LGTM

@jquerybot jquerybot added the CLA: Valid label Aug 5, 2016

@ilyavolodin

This comment has been minimized.

Copy link
Member

commented Aug 5, 2016

LGTM

@ilyavolodin ilyavolodin merged commit 7e1bf01 into eslint:master Aug 5, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jQuery Foundation CLA All authors have signed the CLA
Details

@vitorbal vitorbal deleted the vitorbal:issue6843 branch Aug 5, 2016

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.