Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add fixable note to no-implicit-coercion docs #7096

Merged
merged 1 commit into from Sep 9, 2016

Conversation

Projects
None yet
5 participants
@btmills
Copy link
Member

commented Sep 9, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix ([template](https://github.com/eslint/eslint/blob/master/templates/bug-report.md))
[ ] New rule ([template](https://github.com/eslint/eslint/blob/master/templates/rule-proposal.md))
[ ] Changes an existing rule ([template](https://github.com/eslint/eslint/blob/master/templates/rule-change-proposal.md))
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

If the item you've check above has a template, please paste the template questions here and answer them.

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • n/a I've included tests for my change
  • I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

I noticed while editing the v3.5.0 blog post that, though no-implicit-coercion now supports --fix, its docs weren't updated. I added the message.

Is there anything you'd like reviewers to focus on?

@eslintbot

This comment has been minimized.

Copy link

commented Sep 9, 2016

LGTM

@mention-bot

This comment has been minimized.

Copy link

commented Sep 9, 2016

@btmills, thanks for your PR! By analyzing the annotation information on this pull request, we identified @mysticatea, @pedrottimark and @rpatil26 to be potential reviewers

@jquerybot jquerybot added the CLA: Valid label Sep 9, 2016

@vitorbal

This comment has been minimized.

Copy link
Member

commented Sep 9, 2016

LGTM. Thanks!

@vitorbal vitorbal merged commit f02e52a into master Sep 9, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jQuery Foundation CLA All authors have signed the CLA
Details

@btmills btmills deleted the no-implicit-coercion-fixable-docs branch Dec 12, 2016

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.