Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Update: add enforceInMethodNames option to no-underscore-dangle (fixes #7065) #7234
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
Please check each item to ensure your pull request is ready:
What changes did you make? (Give an overview)
The rule is
Is there anything you'd like reviewers to focus on?
Thanks for the pull request, @gabro! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these?
(More information can be found in our pull request guide.)
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).
After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.
If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.
Hi Vitor, I didn't complete the template because I understood it wasn't needed when there's an issue associated to it.
On 26 Sep 2016, 11:18 +0200, Vitor Balocco firstname.lastname@example.org, wrote:
Thanks for your interest in improving ESLint. Unfortunately, it looks like this issue didn't get enough support from the team and so I'm closing it. While we wish we'd be able to accommodate everyone's requests, we do need to prioritize. We've found that issues failing to reach consensus after a long time tend to never do it, and as such, we close those issues. This doesn't mean the idea isn't interesting, just that it's not something the team can commit to.