Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Lint bin/eslint.js #7243

Merged
merged 1 commit into from Sep 26, 2016

Conversation

Projects
None yet
6 participants
@platinumazure
Copy link
Member

commented Sep 25, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain: Make sure we're linting bin/eslint.js

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • n/a I've included tests for my change
  • n/a I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

Ensured bin/eslint.js was linted (by adding a bin/**/*.js glob to Makefile.js and removing a line from .eslintignore). Then fixed lint errors.

Is there anything you'd like reviewers to focus on?

I turned off no-console and no-process-exit for the file, since we allow those in bin/eslint.js. Let me know if that's not okay (e.g., console.log invocations could be replaced by requiring and using the logger file we have).

Also, this PR subsumes #7241 a bit, oops. If that gets merged first, I'll rebase the branch.

@eslintbot

This comment has been minimized.

Copy link

commented Sep 25, 2016

LGTM

@kaicataldo
Copy link
Member

left a comment

I'm curious - is there a reason we weren't already doing this?

Changes LGTM, but waiting to merge until we fix our currently failing CI tests.

@platinumazure

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2016

@kaicataldo I don't know why it wasn't being linted before. If there is a good reason for it, I hope I will learn of it before closing this PR 😄

@vitorbal
Copy link
Member

left a comment

LGTM as well. Thanks!

@gyandeeps gyandeeps merged commit d154204 into master Sep 26, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jQuery Foundation CLA All authors have signed the CLA
Details

@gyandeeps gyandeeps referenced this pull request Sep 26, 2016

Closed

Chore: codestyle fix #7241

3 of 3 tasks complete

@platinumazure platinumazure deleted the lint-bin branch Sep 26, 2016

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.