Chore: Lint bin/eslint.js #7243

merged 1 commit into from Sep 26, 2016


None yet

6 participants


What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain: Make sure we're linting bin/eslint.js

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • n/a I've included tests for my change
  • n/a I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

Ensured bin/eslint.js was linted (by adding a bin/**/*.js glob to Makefile.js and removing a line from .eslintignore). Then fixed lint errors.

Is there anything you'd like reviewers to focus on?

I turned off no-console and no-process-exit for the file, since we allow those in bin/eslint.js. Let me know if that's not okay (e.g., console.log invocations could be replaced by requiring and using the logger file we have).

Also, this PR subsumes #7241 a bit, oops. If that gets merged first, I'll rebase the branch.

@platinumazure platinumazure Chore: Lint bin/eslint.js



I'm curious - is there a reason we weren't already doing this?

Changes LGTM, but waiting to merge until we fix our currently failing CI tests.


@kaicataldo I don't know why it wasn't being linted before. If there is a good reason for it, I hope I will learn of it before closing this PR 😄


LGTM as well. Thanks!

@gyandeeps gyandeeps merged commit d154204 into master Sep 26, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
jQuery Foundation CLA All authors have signed the CLA
@gyandeeps gyandeeps referenced this pull request Sep 26, 2016

Chore: codestyle fix #7241

3 of 3 tasks complete
@platinumazure platinumazure deleted the lint-bin branch Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment