Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update pull request template (refs eslint/tsc-meetings#20) #7359

Merged
merged 1 commit into from Oct 14, 2016

Conversation

Projects
None yet
8 participants
@btmills
Copy link
Member

btmills commented Oct 14, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • n/a I've included tests for my change
  • n/a I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

Changed the three checkboxes above to become comments. I modified the wording to be imperative, which seemed to make more sense when they become instructions instead of checkboxes.

Is there anything you'd like reviewers to focus on?

Ping @nzakas for review since this was your idea.

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Oct 14, 2016

@btmills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas and @mysticatea to be potential reviewers.

@eslintbot

This comment has been minimized.

Copy link

eslintbot commented Oct 14, 2016

LGTM

@not-an-aardvark
Copy link
Member

not-an-aardvark left a comment

LGTM

**What changes did you make? (Give an overview)**


**Is there anything you'd like reviewers to focus on?**


This comment has been minimized.

Copy link
@not-an-aardvark

not-an-aardvark Oct 14, 2016

Member

This isn't important enough to block merging, but is there a reason to remove these lines? If they're not provided, the user just has to enter them anyway.

This comment has been minimized.

Copy link
@btmills

btmills Oct 14, 2016

Author Member

Good catch! I think I have my editor set to remove extra trailing newlines automatically. I'll add them back.

This comment has been minimized.

Copy link
@btmills

btmills Oct 14, 2016

Author Member

Fixed. Thank you pointing that out.

@btmills btmills force-pushed the pr-template branch from ca4b9ca to d117886 Oct 14, 2016

@eslintbot

This comment has been minimized.

Copy link

eslintbot commented Oct 14, 2016

LGTM

@platinumazure
Copy link
Member

platinumazure left a comment

LGTM, thanks!

@kaicataldo
Copy link
Member

kaicataldo left a comment

LGTM

@kaicataldo kaicataldo merged commit ca1947b into master Oct 14, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jQuery Foundation CLA All authors have signed the CLA
Details

@btmills btmills deleted the pr-template branch Dec 12, 2016

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.