Chore: Update pull request template (refs eslint/tsc-meetings#20) #7359

Merged
merged 1 commit into from Oct 14, 2016

Projects

None yet

8 participants

@btmills
Member
btmills commented Oct 14, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • n/a I've included tests for my change
  • n/a I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

Changed the three checkboxes above to become comments. I modified the wording to be imperative, which seemed to make more sense when they become instructions instead of checkboxes.

Is there anything you'd like reviewers to focus on?

Ping @nzakas for review since this was your idea.

@mention-bot

@btmills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas and @mysticatea to be potential reviewers.

@eslintbot

LGTM

.github/PULL_REQUEST_TEMPLATE.md
**What changes did you make? (Give an overview)**
**Is there anything you'd like reviewers to focus on?**
-
-
@not-an-aardvark
not-an-aardvark Oct 14, 2016 Member

This isn't important enough to block merging, but is there a reason to remove these lines? If they're not provided, the user just has to enter them anyway.

@btmills
btmills Oct 14, 2016 Member

Good catch! I think I have my editor set to remove extra trailing newlines automatically. I'll add them back.

@btmills
btmills Oct 14, 2016 Member

Fixed. Thank you pointing that out.

@btmills btmills Chore: Update pull request template (refs eslint/tsc-meetings#20)
d117886
@eslintbot

LGTM

@platinumazure

LGTM, thanks!

@kaicataldo

LGTM

@kaicataldo kaicataldo merged commit ca1947b into master Oct 14, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jQuery Foundation CLA All authors have signed the CLA
Details
@btmills btmills deleted the pr-template branch Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment