Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix prefer-reflect rule to not crash site gen build #7471

Merged
merged 1 commit into from Oct 31, 2016

Conversation

Projects
None yet
7 participants
@ilyavolodin
Copy link
Member

commented Oct 28, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:
Update rule metadata to stop it from crashing build.

What changes did you make? (Give an overview)
Update rule's metadata

Is there anything you'd like reviewers to focus on?
No

@mention-bot

This comment has been minimized.

Copy link

commented Oct 28, 2016

@ilyavolodin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @keithamus and @mysticatea to be potential reviewers.

@eslintbot

This comment has been minimized.

Copy link

commented Oct 28, 2016

LGTM

@jquerybot

This comment has been minimized.

Copy link

commented Oct 28, 2016

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@kaicataldo
Copy link
Member

left a comment

LGTM

@jquerybot jquerybot added CLA: Valid and removed CLA: Error labels Oct 28, 2016

@platinumazure
Copy link
Member

left a comment

LGTM, hopefully we can make the code handle this more gracefully in the future.

@not-an-aardvark

This comment has been minimized.

Copy link
Member

commented Oct 30, 2016

Added "patch candidate" so that we don't forget to merge this before the patch release.

@kaicataldo kaicataldo merged commit fffdf13 into master Oct 31, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jQuery Foundation CLA All authors have signed the CLA
Details

vitorbal added a commit that referenced this pull request Oct 31, 2016

vitorbal added a commit that referenced this pull request Nov 2, 2016

@alberto alberto deleted the prefer-reflect-fix branch Dec 15, 2016

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.