-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Fix prefer-reflect rule to not crash site gen build #7471
Conversation
@ilyavolodin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @keithamus and @mysticatea to be potential reviewers. |
LGTM |
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, hopefully we can make the code handle this more gracefully in the future.
Added "patch candidate" so that we don't forget to merge this before the patch release. |
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
Update rule metadata to stop it from crashing build.
What changes did you make? (Give an overview)
Update rule's metadata
Is there anything you'd like reviewers to focus on?
No