Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix prefer-reflect rule to not crash site gen build #7471

Merged
merged 1 commit into from
Oct 31, 2016

Conversation

ilyavolodin
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:
Update rule metadata to stop it from crashing build.

What changes did you make? (Give an overview)
Update rule's metadata

Is there anything you'd like reviewers to focus on?
No

@mention-bot
Copy link

@ilyavolodin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @keithamus and @mysticatea to be potential reviewers.

@eslintbot
Copy link

LGTM

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hopefully we can make the code handle this more gracefully in the future.

@not-an-aardvark not-an-aardvark added the patch candidate This issue may necessitate a patch release in the next few days label Oct 30, 2016
@not-an-aardvark
Copy link
Member

Added "patch candidate" so that we don't forget to merge this before the patch release.

@ilyavolodin ilyavolodin added bug ESLint is working incorrectly build This change relates to ESLint's build process accepted There is consensus among the team that this change meets the criteria for inclusion labels Oct 30, 2016
@kaicataldo kaicataldo merged commit fffdf13 into master Oct 31, 2016
@alberto alberto deleted the prefer-reflect-fix branch December 15, 2016 22:06
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly build This change relates to ESLint's build process patch candidate This issue may necessitate a patch release in the next few days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants