Fix: allow escaped backreferences in no-useless-escape (fixes #7472)
#7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
bug
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kaicataldo, @onurtemizkan and @vitorbal to be potential reviewers. |
|
LGTM |
| @@ -36,6 +36,8 @@ const VALID_STRING_ESCAPES = [ | |||
| "\r" | |||
| ]; | |||
|
|
|||
| const DIGITS = Array.from(Array(10).keys(), String); | |||
There was a problem hiding this comment.
I have to admit, I think const DIGITS = "0123456789".split(""); is a bit more readable.
There was a problem hiding this comment.
Yeah, maybe using Array#keys is overkill for 10 elements. I'll use that instead.
not-an-aardvark
force-pushed
the
no-useless-escape-backreferences
branch
from
7977659
to
75bc55f
Compare
|
LGTM |
platinumazure
approved these changes
Oct 28, 2016
mysticatea
approved these changes
Oct 30, 2016
| @@ -53,7 +55,8 @@ const REGEX_GENERAL_ESCAPES = new Set([ | |||
| "W", | |||
| "x", | |||
| "u" | |||
| ]); | |||
| ].concat(DIGITS)); | |||
There was a problem hiding this comment.
FWIW, I think this can be written as new Set("\\0123456789bcdDfnrsStvwWxu") since a string is iterable.
There was a problem hiding this comment.
Good idea, I updated this PR to pass in strings instead of arrays.
|
LGTM |
|
👍 |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
See #7472
What changes did you make? (Give an overview)
This updates
no-useless-escapeto allow digit characters to be escaped in regular expressions. Escaped digits can either be backreferences or octal literals, so the rule should not warn when it encounters them.Is there anything you'd like reviewers to focus on?
Nothing in particular.