Fix: no-useless-return false positive on conditionals (fixes #7477)
#7482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
bug
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea to be a potential reviewer. |
|
LGTM |
not-an-aardvark
commented
Oct 29, 2016
|
|
||
| // FIXME: Re-add this case (removed due to https://github.com/eslint/eslint/issues/7481): | ||
| // https://github.com/eslint/eslint/blob/261d7287820253408ec87c344beccdba2fe829a4/tests/lib/rules/no-useless-return.js#L308-L329 | ||
|
|
not-an-aardvark
added
the
patch candidate
mysticatea
approved these changes
Oct 30, 2016
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (template)
See #7477
What changes did you make? (Give an overview)
This ensures that if a
returnstatement has an argument, and it's on the same code path as another return statement, the first return statement is not considered to be a useless return.Is there anything you'd like reviewers to focus on?
Nothing in particular.