Fix: incorrect indent check for array property access (fixes #7484)
#7485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @mysticatea and @gyandeeps to be potential reviewers. |
not-an-aardvark
added
bug
gyandeeps
approved these changes
Oct 30, 2016
kaicataldo
approved these changes
Oct 31, 2016
|
LGTM. Thanks! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
See #7484
What changes did you make? (Give an overview)
This fixes an issue where array indentation was calculated incorrectly for MemberExpression nodes.
It does this by removing some outdated logic from the
checkIndentInArrayOrObjectBlockfunction. As far as I can tell, this logic is no longer necessary becauseindentno longer has a special case for nested arrays.Is there anything you'd like reviewers to focus on?
We should verify that this removed logic wasn't doing something else that I'm unaware of. It passes all the tests and doesn't appear to be necessary anymore, but it would be good to have confirmation of its original purpose. (It looks like it was introduced in b11c3c4) /cc @gyandeeps @BYK