Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix example for curly "multi-or-nest" option #7597

Merged
merged 1 commit into from Nov 15, 2016

Conversation

Projects
None yet
5 participants
@wwwillchen
Copy link
Contributor

commented Nov 14, 2016

What is the purpose of this pull request? (put an "X" next to item)

[X ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Accidentally wrote the wrong example in my previous PR in #7539. Fixed it so it now correctly shows a good and bad example for having a comment inside an if block for the curly "multi-or-nest" option.

Is there anything you'd like reviewers to focus on?

@mention-bot

This comment has been minimized.

Copy link

commented Nov 14, 2016

@wwwillchen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BenoitZugmeyer, @inikulin and @nzakas to be potential reviewers.

@eslintbot

This comment has been minimized.

Copy link

commented Nov 14, 2016

LGTM

@vitorbal
Copy link
Member

left a comment

LGTM, thanks!

@ilyavolodin ilyavolodin merged commit 100c6e1 into eslint:master Nov 15, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.