Chore: Ensure JS files are checked out with LF #7624

merged 1 commit into from Nov 23, 2016


None yet

8 participants


What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain: Ensure JavaScript files are checked out with LF line endings

What changes did you make? (Give an overview)

Adding eol=lf to .gitattributes for JS files.

Motivation: On my setup, files are checked out with CRLF line endings. eslint-plugin-node has a rule node/shebang which checks for LF line endings. In order to do any development, I have to run dos2unix on bin/eslint.js and then stash those changes when checking out other branches. This PR ensures that bin/eslint.js is checked out with LF line endings, so I don't have to work around the node/shebang rule.

Is there anything you'd like reviewers to focus on?

Hopefully Travis and AppVeyor will continue to pass. Also feel free to check out this branch locally and make sure npm run lint works for you.

@platinumazure platinumazure Chore: Ensure JS files are checked out with LF

@platinumazure, thanks for your PR! By analyzing the history of the files in this pull request, we identified @andzdroid to be a potential reviewer.




LGTM, thanks!

I tried this out on OSX, and it doesn't appear to cause any issues there.


LGTM, thank you!

We are converting line terminators to LF before releasing, so it makes more sense if we develop ESLint with LF.

@gyandeeps gyandeeps merged commit b7432bd into master Nov 23, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
licence/cla Contributor License Agreement is signed.
@platinumazure platinumazure deleted the use-lf-on-js branch Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment