Build: Don't create blogpost links from rule names within other words #7754

Merged
merged 1 commit into from Dec 14, 2016

Projects

None yet

6 participants

@not-an-aardvark
Member
not-an-aardvark commented Dec 13, 2016 edited

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

In the latest blogpost (see here), the word "restricting" in a commit message caused a link to be created to the strict rule documentation.

This commit fixes the issue by requiring a word boundary to be present around the rule name for a URL to be inserted.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@not-an-aardvark not-an-aardvark Build: Don't create blogpost links from rule names within other words
This caused an issue in the latest blogpost (see [here](https://github.com/eslint/eslint.github.io/blob/0709ac422ed42219219887e9468ca867ed18f4f4/_posts/2016-12-12-eslint-v3.12.1-released.md#documentation)). The word "restricted" in a commit message caused a link to be created to the [`strict`](http://eslint.org/docs/rules/strict) rule documentation.

This commit fixes the issue by requiring a word boundary to be present around the rule name for a URL to be inserted.
f99d6be
@mention-bot

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas and @mikesherov to be potential reviewers.

@eslintbot

LGTM

@platinumazure

LGTM, thanks!

@btmills

LGTM, thanks!

@btmills btmills merged commit 5344751 into master Dec 14, 2016

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@not-an-aardvark not-an-aardvark deleted the rule-word-subsets branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment