Fix: prefer-destructuring reporting compound assignments (fixes #7881) #7882

Merged
merged 1 commit into from Jan 9, 2017

Projects

None yet

8 participants

@not-an-aardvark
Member

What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (see #7881)

What changes did you make? (Give an overview)

This updates prefer-destructuring to avoid reporting compound assignments such as foo += bar.foo, since these assignments can't be replaced with destructuring assignments.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark Fix: prefer-destructuring reporting compound assignments (fixes #7881)
6c1a312
@mention-bot

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexlafroscia to be a potential reviewer.

@eslintbot

LGTM

@kaicataldo

LGTM. Thanks for fixing this!

@ilyavolodin ilyavolodin merged commit 3fc4e3f into master Jan 9, 2017

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@not-an-aardvark not-an-aardvark deleted the prefer-destructuring-compound-assignments branch Jan 9, 2017
@keylocation-bot keylocation-bot referenced this pull request in singapore/lint-condo Jan 11, 2017
Merged

Update dependency eslint to version 3.13.1 #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment