Chore: Enable comma-dangle on ESLint codebase (fixes #7725) #7906

Merged
merged 1 commit into from Jan 12, 2017

Projects

None yet

5 participants

@not-an-aardvark
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This enables comma-dangle: never on the ESLint codebase, as discussed in #7725.

All of the changes were made with ESLint's autofixer.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark Chore: Enable comma-dangle on ESLint codebase (fixes #7725)
7cd5d6a
@eslintbot

LGTM

@mention-bot

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea, @daltones and @taion to be potential reviewers.

@kaicataldo

LGTM, thanks!

@kaicataldo
Member

Merging this now to avoid merge conflicts. Having done a few PRs like this myself, I know how annoying that can be.

@kaicataldo kaicataldo merged commit d6150e3 into master Jan 12, 2017

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@not-an-aardvark not-an-aardvark deleted the comma-dangle, branch Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment