Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set recommended true for no-global-assign #8218

Merged

Conversation

Projects
None yet
7 participants
@liubinyi
Copy link
Contributor

commented Mar 8, 2017

set recommended true for no-global-assign
tried to fix issue #8215

@mention-bot

This comment has been minimized.

Copy link

commented Mar 8, 2017

@liubinyi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alberto, @mysticatea and @kaicataldo to be potential reviewers.

@jsf-clabot

This comment has been minimized.

Copy link

commented Mar 8, 2017

CLA assistant check
All committers have signed the CLA.

@eslintbot

This comment has been minimized.

Copy link

commented Mar 8, 2017

Thanks for the pull request, @liubinyi! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@platinumazure
Copy link
Member

left a comment

Thanks for contributing! Don't worry about the commit message note from eslintbot, we can tweak the commit message on merge.

@platinumazure platinumazure merged commit ce6ff56 into eslint:master Mar 9, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@liubinyi

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2017

Thanks @platinumazure @ilyavolodin for taking care of that! i will be more carefully next time.

@vitorbal

This comment has been minimized.

Copy link
Member

commented Mar 9, 2017

Thank you for your contribution, @liubinyi! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.