New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix misleading comment in ConfigCache.js #8799

Merged
merged 1 commit into from Jun 25, 2017

Conversation

Projects
None yet
3 participants
@not-an-aardvark
Member

not-an-aardvark commented Jun 25, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

In a previous iteration of the glob config implementation, the ConfigCache class was not exported from its module. However, now it is exported. This commit removes an outdated comment that stated the opposite.

Is there anything you'd like reviewers to focus on?

Nothing in particular

Chore: Fix misleading comment in ConfigCache.js
In a previous iteration of the glob config implementation, the ConfigCache class was not exported from its module. However, now it is exported. This commit removes an outdated comment that stated the opposite.
@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented Jun 25, 2017

LGTM

@not-an-aardvark not-an-aardvark merged commit d2e88ed into master Jun 25, 2017

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@not-an-aardvark not-an-aardvark deleted the fix-misleading-config-cache-comment branch Jun 25, 2017

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.