Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correct comma-dangle JSON schema #8864

Merged
merged 2 commits into from Jul 4, 2017

Conversation

epoberezkin
Copy link

  • fixes typos ($refs is used instead of $ref)
  • “defs” is inconsistent with the use of “definitions” in other schemas
  • uses full JSON schema format instead of array of schemas, as currently $ref inside array of schemas is unsupported

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Schema in comma-dangle is fixed as described above.
Update documentation about $ref usage when rule.schema is an array of schemas.

Is there anything you'd like reviewers to focus on?

Documentation update

* $refs is not part of the spec
* “defs” is inconsistent with the use of “definitions” in other schemas
@eslintbot
Copy link

LGTM

1 similar comment
@eslintbot
Copy link

LGTM

@eslintbot
Copy link

LGTM

@epoberezkin epoberezkin changed the title [WIP] Fix: correct comma-dangle JSON schema Fix: correct comma-dangle JSON schema Jul 2, 2017
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark added the chore This change is not user-facing label Jul 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants