Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Chore: improve performance of `indent` rule #8905
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This updates the
This results in a 19% end-to-end performance increase (!) according to our
Rule-specific benchmark on ESLint codebase
Is there anything you'd like reviewers to focus on?
I tried to write descriptive comments to explain what's going on. Is there anything that's unclear or could be improved?
referenced this pull request
Jul 10, 2017
I've made a few small improvements -- now this improves end-to-end performance by 20%.
(I think my laptop has a different battery level than when I ran the benchmark in the original PR, so these two runs are comparable to each other, but they're not comparable to the original two runs in terms of absolute time.)