New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blockBindings references #9446

Merged
merged 4 commits into from Oct 16, 2017

Conversation

Projects
None yet
4 participants
@Hirse
Contributor

Hirse commented Oct 16, 2017

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Fix the typo in no-use-before-define docs (declaring variable c before using it c++), see #8368
  • Remove the comment // With blockBindings: true in no-use-before-define docs, see #8368
  • Remove references to blockBindings in
    • Comments
    • Test descriptions
    • Example ecmaFeatures used in tests

Is there anything you'd like reviewers to focus on?
No

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented Oct 16, 2017

LGTM

@platinumazure

LGTM, thanks for contributing!

@not-an-aardvark not-an-aardvark merged commit 7e891a0 into eslint:master Oct 16, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

not-an-aardvark added a commit that referenced this pull request Oct 16, 2017

Docs: Remove blockBindings references (#9446)
* Docs: Remove blockBindings in no-use-before-define (fixes #8368)

* Chore: Remove blockBindings reference in no-catch-shadow

* Chore: Remove blockBindings reference in test desctription

* Chore: Use existing ecmaFeatures in tests

@Hirse Hirse deleted the Hirse:issue8368 branch Oct 18, 2017

@eslint eslint bot locked and limited conversation to collaborators Apr 15, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.