New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: should not convert non-consecutive line comments to a single blo… #9475

Merged
merged 2 commits into from Oct 22, 2017

Conversation

Projects
None yet
5 participants
@Aladdin-ADD
Member

Aladdin-ADD commented Oct 18, 2017

…ck comment(fixes #9462)

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix (template)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@Aladdin-ADD

This comment has been minimized.

Show comment
Hide comment
@Aladdin-ADD

Aladdin-ADD Oct 18, 2017

Member

I need to add some more tests. add "do not merge" label.

Member

Aladdin-ADD commented Oct 18, 2017

I need to add some more tests. add "do not merge" label.

@eslint eslint deleted a comment from eslintbot Oct 18, 2017

@eslint eslint deleted a comment from eslintbot Oct 18, 2017

@Aladdin-ADD Aladdin-ADD requested a review from not-an-aardvark Oct 18, 2017

@platinumazure

LGTM, thanks for contributing!

@not-an-aardvark

LGTM, I just have a suggestion for a test.

options: ["starred-block"]
},
{
code: `

This comment has been minimized.

@not-an-aardvark

not-an-aardvark Oct 22, 2017

Member

Can you add a test for converting two separate line groups?

/* eslint multiline-comment-style: [error, starred-block] */

// foo
// bar

// baz
// qux

should get fixed to:

/*
 * foo
 * bar
 */

/*
 * baz
 * qux
 */
@not-an-aardvark

not-an-aardvark Oct 22, 2017

Member

Can you add a test for converting two separate line groups?

/* eslint multiline-comment-style: [error, starred-block] */

// foo
// bar

// baz
// qux

should get fixed to:

/*
 * foo
 * bar
 */

/*
 * baz
 * qux
 */
@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented Oct 22, 2017

LGTM

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented Oct 22, 2017

LGTM

@eslint eslint deleted a comment from eslintbot Oct 22, 2017

@eslint eslint deleted a comment from eslintbot Oct 22, 2017

@eslint eslint deleted a comment from eslintbot Oct 22, 2017

@eslint eslint deleted a comment from eslintbot Oct 22, 2017

@eslint eslint deleted a comment from eslintbot Oct 22, 2017

@Aladdin-ADD Aladdin-ADD merged commit 2fa64b7 into eslint:master Oct 22, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@Aladdin-ADD Aladdin-ADD deleted the Aladdin-ADD:issue9462 branch Oct 22, 2017

@eslint eslint bot locked and limited conversation to collaborators Apr 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.