New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Incorrect link to related rule #9477

Merged
merged 1 commit into from Oct 20, 2017

Conversation

Projects
None yet
6 participants
@plumpNation
Contributor

plumpNation commented Oct 18, 2017

padding-line-between-statement should be padding-line-between-statements

What is the purpose of this pull request? (put an "X" next to item)

[X ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Edited a linked rule to match the actual rule name. It was hitting the 404 page.

Is there anything you'd like reviewers to focus on?
Nope.

@jsf-clabot

This comment has been minimized.

Show comment
Hide comment
@jsf-clabot

jsf-clabot Oct 18, 2017

CLA assistant check
All committers have signed the CLA.

jsf-clabot commented Oct 18, 2017

CLA assistant check
All committers have signed the CLA.

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot Oct 18, 2017

Thanks for the pull request, @plumpNation! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

eslintbot commented Oct 18, 2017

Thanks for the pull request, @plumpNation! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@platinumazure

LGTM, thanks for contributing!

@platinumazure

This comment has been minimized.

Show comment
Hide comment
@platinumazure

platinumazure Oct 18, 2017

Member

Thanks @plumpNation for the PR! Could you please sign our Contributor License Agreement? Without a signature, unfortunately we can't accept this contribution 😄

Member

platinumazure commented Oct 18, 2017

Thanks @plumpNation for the PR! Could you please sign our Contributor License Agreement? Without a signature, unfortunately we can't accept this contribution 😄

Docs: Incorrect link to related rule
`padding-line-between-statement` should be `padding-line-between-statements`
@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented Oct 18, 2017

LGTM

@plumpNation

This comment has been minimized.

Show comment
Hide comment
@plumpNation

plumpNation Oct 20, 2017

Contributor

Done, my pleasure.

Contributor

plumpNation commented Oct 20, 2017

Done, my pleasure.

@ilyavolodin ilyavolodin merged commit 51bdb2f into eslint:master Oct 20, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@eslint eslint bot locked and limited conversation to collaborators Apr 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.