New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: use consistent terminology & fix link etc. #9490

Merged
merged 2 commits into from Oct 20, 2017

Conversation

Projects
None yet
4 participants
@Aladdin-ADD
Member

Aladdin-ADD commented Oct 20, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)
some small improvement:

  • terminology: Node.js, ECMAScript, ESLint...
  • link: http => https, avoid redirect...

Is there anything you'd like reviewers to focus on?

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented Oct 20, 2017

LGTM

Docs: use consistent terminology & fix link etc.
+ terminology: Node.js, ECMAScript, ESLint...
+ link: http => https, avoid redirect...
@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented Oct 20, 2017

LGTM

@platinumazure

LGTM, just one comment. Thanks!

@@ -2,7 +2,7 @@
Invalid or irregular whitespace causes issues with ECMAScript 5 parsers and also makes code harder to debug in a similar nature to mixed tabs and spaces.
Various whitespace characters can be inputted by programmers by mistake for example from copying or keyboard shortcuts. Pressing Alt + Space on OS X adds in a non breaking space character for example.
Various whitespace characters can be inputted by programmers by mistake for example from copying or keyboard shortcuts. Pressing Alt + Space on macOS adds in a non breaking space character for example.

This comment has been minimized.

@platinumazure

platinumazure Oct 20, 2017

Member

Should this read "Mac OS"?

@platinumazure

platinumazure Oct 20, 2017

Member

Should this read "Mac OS"?

This comment has been minimized.

@Aladdin-ADD

Aladdin-ADD Oct 20, 2017

Member

seems the official name is macOS~
image

@Aladdin-ADD

Aladdin-ADD Oct 20, 2017

Member

seems the official name is macOS~
image

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented Oct 20, 2017

LGTM

@Aladdin-ADD Aladdin-ADD merged commit b3d7532 into eslint:master Oct 20, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@Aladdin-ADD Aladdin-ADD deleted the Aladdin-ADD:improve-docs branch Oct 20, 2017

@eslint eslint bot locked and limited conversation to collaborators Apr 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.