New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Amend rule document to correct and complete it (refs #6251). #9498

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
5 participants
@jrpool
Contributor

jrpool commented Oct 21, 2017

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Corrected and completed documentation on rule object-property-newline to complete step 1 of plan to handle issue #6251.

Is there anything you'd like reviewers to focus on?
This rule seems to treat shorthand and computed properties correctly without the ecmaversion: 6 parser option. Should the documentation nevertheless instruct users to invoke that option for these property syntaxes? Also, the tests include experimental object rest spread cases, but the general user documentation cautions against writing rules for this syntax. Should this rule’s documentation state that this syntax is supported?

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented Oct 21, 2017

LGTM

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented Oct 22, 2017

LGTM

@gyandeeps gyandeeps merged commit c529de9 into eslint:master Oct 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@jrpool jrpool deleted the jrpool:opnewline branch Oct 28, 2017

@eslint eslint bot locked and limited conversation to collaborators Apr 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.