New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add tests to cover array and object values and leading commas. #9502

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
5 participants
@jrpool
Contributor

jrpool commented Oct 22, 2017

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
Add tests to an existing rule.

What changes did you make? (Give an overview)
Added tests to improve coverage and relocated 2 existing tests into the appropriate section.
This PR implements step 2 of my plan to handle issue 6251 (refs #6251).
Is there anything you'd like reviewers to focus on?

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot commented Oct 22, 2017

LGTM

@gyandeeps gyandeeps merged commit f9c6673 into eslint:master Oct 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@jrpool jrpool deleted the jrpool:opnl-step-2 branch Oct 28, 2017

@eslint eslint bot locked and limited conversation to collaborators Apr 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.