New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update ISSUE_TEMPLATE.md #9504

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
3 participants
@Aladdin-ADD
Member

Aladdin-ADD commented Oct 23, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@not-an-aardvark

I think this could be confusing if the user doesn't know the difference between a local/global installation. Maybe it would be better to add this to the "What did you do?" question.

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot Oct 24, 2017

Thanks for the pull request, @Aladdin-ADD! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

eslintbot commented Oct 24, 2017

Thanks for the pull request, @Aladdin-ADD! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@eslint eslint deleted a comment from eslintbot Oct 24, 2017

@@ -43,6 +43,10 @@
```

This comment has been minimized.

@not-an-aardvark

not-an-aardvark Oct 24, 2017

Member

Nitpick: It might be good to also add a comment here:

<!-- Paste the command you used to run ESLint: -->
@not-an-aardvark

not-an-aardvark Oct 24, 2017

Member

Nitpick: It might be good to also add a comment here:

<!-- Paste the command you used to run ESLint: -->
@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot Oct 24, 2017

Thanks for the pull request, @Aladdin-ADD! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

eslintbot commented Oct 24, 2017

Thanks for the pull request, @Aladdin-ADD! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@Aladdin-ADD Aladdin-ADD changed the title from Update ISSUE_TEMPLATE.md to Docs: Update ISSUE_TEMPLATE.md Oct 24, 2017

@eslintbot

This comment has been minimized.

Show comment
Hide comment
@eslintbot

eslintbot Oct 24, 2017

Thanks for the pull request, @Aladdin-ADD! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

eslintbot commented Oct 24, 2017

Thanks for the pull request, @Aladdin-ADD! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@Aladdin-ADD Aladdin-ADD merged commit 720b6d5 into master Oct 24, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@Aladdin-ADD Aladdin-ADD deleted the Aladdin-ADD-patch-1 branch Oct 24, 2017

@eslint eslint bot locked and limited conversation to collaborators Apr 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.