New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-var don't fix globals (fixes #9520) #9525

merged 1 commit into from Oct 27, 2017


None yet
4 participants

mysticatea commented Oct 27, 2017

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Fixes #9520.

What changes did you make? (Give an overview)

This PR makes no-var rule not fixing global variables.
If the program has special scope (sourceType: "module" or ecmaFeatures: { globalReturn: true }), the rule keeps the current behavior.

Is there anything you'd like reviewers to focus on?

Nothing in particular.


LGTM, thanks!

@gyandeeps gyandeeps merged commit d80b9d0 into master Oct 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
licence/cla Contributor License Agreement is signed.

@gyandeeps gyandeeps deleted the no-var/dont-fix-globals branch Oct 27, 2017

@eslint eslint bot locked and limited conversation to collaborators Apr 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.