Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add NewExpression support to comma-style #9591

Merged
merged 1 commit into from Jan 20, 2018

Conversation

@RazerM
Copy link
Contributor

RazerM commented Nov 8, 2017

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What rule do you want to change?

comma-style

Does this change cause the rule to produce more or fewer warnings?

more, if new option is enabled

How will the change be implemented? (New option, new default behavior, etc.)?

New exceptions.NewExpression option, which defaults to true, and can be set to false for the new behaviour.

Please provide some example code that this change will affect:

new Date(
  2017
  ,11
  ,7)

What does the rule currently do for this code?

No errors.

What will the rule do after it's changed?

Gives an error that ',' should be placed last.

What changes did you make? (Give an overview)

I added a NewExpression exception in the same style as the existing comma-style exceptions (FunctionExpression etc.)

Is there anything you'd like reviewers to focus on?

@ilyavolodin

This comment has been minimized.

Copy link
Member

ilyavolodin commented Dec 23, 2017

@eslint/eslint-team Does anyone else wants to support this change? We need one more 👍 and a champion

@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Jan 4, 2018

This seems like a reasonable enhancement to me! We just need a champion now.

@platinumazure platinumazure self-assigned this Jan 6, 2018
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Jan 6, 2018

I'll champion this. Marking as accepted.

@platinumazure platinumazure added accepted and removed evaluating labels Jan 6, 2018
Copy link
Member

platinumazure left a comment

LGTM, thanks for contributing!

Copy link
Member

platinumazure left a comment

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit af043eb into eslint:master Jan 20, 2018
6 checks passed
6 checks passed
Release monitor See 'release-monitor'
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@not-an-aardvark

This comment has been minimized.

Copy link
Member

not-an-aardvark commented Jan 20, 2018

Thanks for contributing!

@RazerM RazerM deleted the RazerM:comma-style-new-expression branch Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.