Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Chore: Use messageIds in some of the core rules #9648
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
Update core rules matching
This PR also updates the tests for those rules to use messageIds, making the tests easier to read IMHO.
Is there anything you'd like reviewers to focus on?
platinumazure left a comment •
I left some suggestions for messageId name changes in a few files.
I think my rationale for what makes some messageIds better than others can be summarized as follows:
Hope this makes sense, and please speak up if you think this vision is not sensible.
@j-f1 In that their metadata will now contain message templates, which could theoretically be used by integrations. As I said, it's backwards-compatible and in fact the behavior won't change one bit, but it does seem like a backwards-compatible API change.
Put another way, we're adding a new feature to the rule metadata, and that should be semver-minor, not semver-patch.